arshilkxwork commented on PR #828: URL: https://github.com/apache/hugegraph-toolchain/pull/828#issuecomment-6284910817
Thanks for the review. Added in 597d036d: `test_release_profile.py` now counts the source-plugin executions with a `test-jar` or `test-jar-no-fork` goal, expecting one for Tools and none elsewhere, each with a single such goal. It catches the case you describe: with an extra `test-jar` execution added to the Tools POM it fails with `1 != 2 : test source jar producers`, and it passes on this branch. Artifact-level smoke evidence, from `mvn -B -ntp -Papache-release -DskipTests -pl .,hugegraph-client,hugegraph-tools,hugegraph-spark-connector,hugegraph-loader deploy -DaltDeploymentRepository=smoke::default::file://<dir>` on Java 17 and Maven 3.10.0, signed with a temporary RSA 2048 key (GnuPG 2.5). This PR's run used the POMs of 2f55194, which 597d036d does not change; the master run used 431b45b3. | Module | Artifacts | `.asc`, this PR | `.asc.asc`, this PR | `.asc.asc`, master | |---|---:|---:|---:|---:| | hugegraph-toolchain (pom, source-release zip) | 2 | 2 | 0 | 2 | | hugegraph-client | 4 | 4 | 0 | 4 | | hugegraph-loader | 4 | 4 | 0 | 4 | | hugegraph-spark-connector | 4 | 4 | 0 | 4 | | hugegraph-tools | 6 | 6 | 0 | 6 | Artifacts are counted without signatures, checksums and metadata: pom, jar, sources and javadoc for client, Loader and Spark, plus `-tests.jar` and `-test-sources.jar` for Tools. - All 20 signatures from this PR's run passed `gpg --verify` against their artifacts. The temporary key was deleted afterwards, so I can't re-verify those files now. - "already attached, replace previous instance" warnings: 23 on master, none on this PR. The one warning left on both is the Spark shade plugin replacing the main jar. - Apart from the `.asc.asc` files, both runs deployed the same file names. - The source-release zip from this PR's run contains no `.git`. Extracted with `.github` removed, `mvn -B -ntp -DskipTests package -pl .,hugegraph-client,hugegraph-tools,hugegraph-spark-connector,hugegraph-loader` succeeds. Hubble was not part of this run, and no Apache staging deploy was done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
