bitflicker64 commented on code in PR #3356:
URL: https://github.com/apache/hugegraph/pull/3356#discussion_r4328416898
##########
hugegraph-pd/hg-pd-core/src/main/java/org/apache/hugegraph/pd/TaskScheduleService.java:
##########
@@ -582,6 +630,257 @@ public synchronized Map<Integer, Long>
balancePartitionLeader(boolean immediatel
return results;
}
+ /**
+ * The periodic entry of leader balancing. Calls balancePartitionLeader
only when the
+ * leader count per store has drifted further apart than
pd.balance-leader-max-skew and does
+ * not already match the planner's targets, so a balanced cluster sees no
transfers. Skipped while a shard group is not Normal, has no
Review Comment:
Minor: This Javadoc line is 138 characters. The project limit is 120
(`max_line_length = 120` in `.editorconfig`, `LineLength` max 120 in
`style/checkstyle.xml`), and the rest of this file wraps at 100. It looks like
the sentence added in e6c1bcb0d was not rewrapped. Please wrap it, for example:
```suggestion
* not already match the planner's targets, so a balanced cluster sees
no transfers.
* Skipped while a shard group is not Normal, has no
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
