imbajin commented on code in PR #3326:
URL: https://github.com/apache/hugegraph/pull/3326#discussion_r4348809606
##########
.github/workflows/server-ci.yml:
##########
@@ -13,12 +13,12 @@ on:
description: Tests to run on the selected branch
type: choice
default: mainline
- options: [mainline, distributed, macos-arm, hbase, riscv64, codeql,
full]
+ options: [mainline, dependencies, distributed, macos-arm, hbase,
riscv64, codeql, full]
-# A new PR head replaces its old run; scheduled and manual runs stay
independent.
+# New PR heads and master pushes replace their old runs; scheduled and manual
runs stay independent.
concurrency:
- group: ${{ github.workflow }}-${{ github.event_name }}-${{
github.event.pull_request.number || github.run_id }}-${{ github.run_attempt ==
1 && 'head' || format('rerun-{0}', github.run_id) }}
- cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+ group: ${{ github.workflow }}-${{ github.event_name }}-${{
github.event.pull_request.number || (github.event_name == 'push' && github.ref
== 'refs/heads/master' && github.ref) || github.run_id }}-${{
github.run_attempt == 1 && 'head' || format('rerun-{0}', github.run_id) }}
Review Comment:
⚠️ Important. Blocking: yes. Summary: A master push and a manual
`dependencies` run can submit to the same baseline stream concurrently.
Evidence: this concurrency key includes `github.event_name`, separating the two
events, while both reach the writer with the same correlator and detector; the
SHA recheck after the POST can fail only after the snapshot was accepted.
GitHub keeps only the latest submission for a correlator/detector pair
([dependency submission
API](https://docs.github.com/en/rest/dependency-graph/dependency-submission)).
Please serialize baseline writes across these event types or guarantee a
current-tip snapshot is submitted after any stale write.
##########
.github/workflows/pd-store-ci.yml:
##########
@@ -567,7 +520,43 @@ jobs:
tail -n 120 "$report" || true
done
+ - name: Verify Store stop failure propagation and PID retention
+ if: ${{ !cancelled() }}
+ run: bash
hugegraph-server/hugegraph-dist/src/assembly/travis/test-stop-hugegraph-store.sh
+
+ - name: Run Java runtime log checker tests
+ if: ${{ !cancelled() }}
+ run: bash "$TRAVIS_DIR/test-check-java-runtime-logs.sh"
+
+ - name: Run JaCoCo report validator tests
+ if: ${{ !cancelled() }}
+ run:
hugegraph-server/hugegraph-dist/src/assembly/travis/test-check-jacoco-report.sh
+
+ - name: Run Codecov upload configuration tests
+ if: ${{ !cancelled() }}
+ run:
hugegraph-server/hugegraph-dist/src/assembly/travis/test-codecov-upload-config.sh
+
+ - name: Check TinkerPop branch and report gates
+ if: ${{ !cancelled() }}
+ run: bash
hugegraph-server/hugegraph-dist/src/assembly/travis/test-tinkerpop-reports.sh
Review Comment:
⚠️ Important. Blocking: no. Summary: The TinkerPop report contract test is
not routed when its script changes. Evidence: this check runs in the standalone
`struct` job and in `store`, but
`.github/scripts/ci-policy.py::CONTRACT_SUITES` has no entry for
`test-tinkerpop-reports.sh`; the generic `hugegraph-server/hugegraph-dist/`
route selects server/docker/macOS, not the job that runs this test. Please add
a contract-suite mapping for this script (at least `struct`) so changes to it
exercise the check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
