imbajin opened a new pull request, #854:
URL: https://github.com/apache/hugegraph-toolchain/pull/854

   Switching from a completed graph query to asynchronous mode could dispose 
the canvas while G6 Minimap still had a delayed refresh pending. The query 
itself succeeded, but the stale callback later threw `Cannot read properties of 
undefined (reading 'getData')`. A read-only live 60-vertex query reproduced the 
stack in `Minimap.getElements → renderMinimap → debounce`.
   
   Extend the existing pinned G6 5.1.1 patch so Minimap's delayed render and 
throttled transform callbacks stop when their owning plugin has been destroyed. 
Source, ESM and CommonJS copies stay aligned, and the lockfile records the 
updated patch hash. The checked-in third-party inventory is regenerated for the 
resulting lockfile and patch fingerprints. Active graph failures still 
propagate; this does not catch arbitrary errors or substitute empty graph data.
   
   Validation: six focused suites / 136 tests passed, including five 
regressions against the real published plugin. Before this fix, four disposal 
regressions failed and the active-error propagation check passed. Targeted 
ESLint, bilingual i18n validation, TypeScript and the production build passed 
using an isolated frozen dependency installation. The notice generator test and 
deterministic regeneration pass; the frontend source tree is identical to the 
browser-tested candidate.
   
   The same actual Chromium workflow queried a controlled 60-node fixture, 
switched to async mode and returned to querying three times: current master 
produced three matching page errors; the candidate produced zero, with no 
unexpected API calls. The recovered graph and minimap still displayed all 60 
nodes. A separate live read-only browser captured the original stack; candidate 
fixture results do not claim live cluster or throughput validation.
   
   Before/after UI screenshots were captured and inspected outside Git. Native 
public image-attachment upload is unavailable in this session, so no public 
image URLs are claimed. Related [Hubble bug 
record](https://chatgpt.com/space/page_62cf6a23a284819196000f124fdd6990).
   
   Based on the freshly checked org and ASF master 
`8eb5de9009d494842f6b8ee58b83e1f1248c8aff`. This is independent of the 
login-connection and schema-selection fixes.
   
   Source review: https://github.com/hugegraph/hugegraph-toolchain/pull/99
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to