bitflicker64 commented on PR #3382: URL: https://github.com/apache/hugegraph/pull/3382#issuecomment-6408009382
The earlier review comments below still apply at 55ae8fe; this head does not fix them. - ‼️ Critical: There is still a time-of-check/time-of-use window after the equality check. `meta.getOne(storeKey)` can return the inspected bytes, then a concurrent `put` or `keepAlive` can renew the value before this separate `meta.remove(storeKey)` Raft operation; cleanup will delete the renewed value and leave its new TTL marker behind. Please perform the compare-and-delete and marker removal atomically in one Raft entry, and cover a renewal after the equality check. (https://github.com/apache/hugegraph/pull/3382#discussion_r4341950588) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
