imbajin commented on PR #750: URL: https://github.com/apache/hugegraph-toolchain/pull/750#issuecomment-6431862220
Closing because this setting has no observable effect under Hubble's current CORS policy. `GlobalCorsConfig` deliberately keeps same-origin access as the default and does not configure any allowed origins. Cross-origin preflight requests are rejected before `Access-Control-Max-Age` can be written; same-origin requests do not need a CORS preflight. Adding `setMaxAge(3600L)` therefore does not provide the advertised cache behavior, consistent with the existing review. A future cross-origin feature should define an explicit trusted-origin allowlist and verify allowed and rejected preflight requests together. There is no current requirement in this PR to change that access policy. Thank you for the proposal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
