bitflicker64 commented on PR #3413:
URL: https://github.com/apache/hugegraph/pull/3413#issuecomment-6461406605

   ## Automated review summary: score 10/10, no confirmed introduced defects
   
   Reviewed head: `796789eed0fea54c4b9bfdb30c969dbfeacda6ad` (diff base 
`f04d5cc8`). This is a multi-agent review coordinated through HG-review-team. 
Two of four review lanes have reported so far: Codex and Claude. The Copilot 
and AGY lanes are still pending; if they find anything material, this comment 
will be edited.
   
   **What changed:** one exact key, 
`io.grpc.netty.shaded.io.grpc.netty.useCustomAllocator`, is added to 
`WHITE_SYSTEM_PROPERTIES`. `checkPropertyAccess` still matches with 
`Set.contains`, so similar or prefixed keys and sensitive properties are still 
denied. `checkPropertiesAccess` is unchanged.
   
   **Evidence:**
   - **Root cause:** `javap` on `grpc-netty-shaded-1.55.3` shows that 
`Utils.getByteBufAllocator(boolean)` reads this property on every call. Warming 
the allocator up at startup therefore cannot avoid the error reported in #3412.
   - **Tests on JDK 17:** at this head, `HugeSecurityManagerGrpcTest` passes 
7/7. With the base `HugeSecurityManager.java` and the new tests, 4 of 7 fail 
with `Not allowed to access system property(...useCustomAllocator) via 
Gremlin`, so the new tests do catch the regression.
   
   **Not covered by this PR, and not counted against it:**
   - When a gRPC allocator holder is initialized for the first time, it also 
reads `...netty.allocator.maxOrder`.
   - `checkConnect` denies connections from Gremlin threads.
   
   Both behave the same at base and at head, and neither was shown to be 
reachable on the normal HStore path, where the PD client creates its channels 
outside Gremlin.
   
   **Limits:** no reviewer ran a live HStore/PD cluster or an end-to-end 
Gremlin-over-HTTP reproduction. The evidence above is component-level only.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to