bitflicker64 commented on code in PR #862:
URL:
https://github.com/apache/hugegraph-toolchain/pull/862#discussion_r4411482126
##########
hugegraph-hubble/hubble-fe/src/i18n/resources/en-US/modules/analysis.json:
##########
@@ -1069,7 +1069,10 @@
"check_result": "View Result",
"check_reason": "View Reason",
"collapse_result": "Hide Result"
- }
+ },
+ "result_error_unknown": "The service returned no specific reason. Check
the Hubble and graph compute service logs.",
Review Comment:
Important: `result_error_unknown` and `vermeer_result_retry_hint` end with a
period in both `en-US` and `zh-CN` `analysis.json`, which fails four cases in
`src/i18n/ui-copy-punctuation.test.js` (4 failed, 2446 passed in the Hubble CI
run for this head). Drop the terminal `.`/`。` from these four strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
