imbajin commented on code in PR #859:
URL:
https://github.com/apache/hugegraph-toolchain/pull/859#discussion_r4412610698
##########
hugegraph-hubble/hubble-be/src/main/java/org/apache/hugegraph/service/query/QueryService.java:
##########
@@ -311,13 +311,17 @@ private ResultSet executeGremlin(String gremlin,
HugeClient client) {
}
throw this.serverQueryException(e);
} catch (ClientException e) {
+ for (Throwable cause = e; cause != null; cause = cause.getCause())
{
+ if (cause instanceof java.net.SocketTimeoutException ||
Review Comment:
⚠️ The REST client can throw a raw `SocketTimeoutException`:
`HugeClientFakeServerTest.testSlowGraphRequestTimesOut` asserts that behavior,
and Gremlin requests use the same client through `GremlinAPI.post`. Such an
exception bypasses this `ClientException` branch and reaches the generic
exception handler, so a real transport timeout still returns the generic
failure instead of HTTP 504. Please classify timeout causes in the generic
exception path as well and add a slow HTTP Gremlin request test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
