bitflicker64 commented on code in PR #3388:
URL: https://github.com/apache/hugegraph/pull/3388#discussion_r4416503894


##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/server/HugeGraphWsAndHttpChannelizer.java:
##########
@@ -36,6 +39,15 @@ public void init(ServerGremlinExecutor executor) {
                 this.graphManager, this.settings));
     }
 
+    public MessageTextSerializer<?> jsonSerializer() {
+        MessageSerializer<?> serializer =
+                this.serializers.get("application/json");
+        E.checkState(

Review Comment:
   Important: when `gremlin-server.yaml` has no `application/json` serializer 
(GraphBinary only, or a GraphSON entry that fails to load), this `checkState` 
aborts `HugeGraphServer` startup, which forwarding never did. Keep HTTP 
forwarding with a warning when the serializer is missing, as for the other 
unsupported configurations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to