bitflicker64 commented on code in PR #861:
URL:
https://github.com/apache/hugegraph-toolchain/pull/861#discussion_r4416505265
##########
hugegraph-hubble/hubble-fe/src/modules/GraphAnalysis/index.js:
##########
@@ -223,21 +224,19 @@ const GraphAnalysisHome = props => {
onGraphInfoChange={onGraphInfoChange}
showOlapSwitch={moduleName !== ASYNCTASKS}
showNavigationButton={moduleName !== ASYNCTASKS}
+ showGraphLoad={moduleName === ALGORITHMS && algorithmEngine ===
'olap'}
isOlapModeEnable={currentOlapMode}
isOlapModeLoading={isOlapModeLoading}
onOlapModeChange={onOlapModeChange}
/>
);
const renderModule = () => {
Review Comment:
Important: dropping the `vermeerReady` gate leaves the `Spin` import (line
21) and the `vermeerLoading` state (line 49) unused, so `pnpm lint` (`eslint
src --max-warnings=0`) fails on `no-unused-vars` in `hubble-ci`. Remove the
`Spin` import and the `vermeerLoading` state with its `setVermeerLoading` calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
