bitflicker64 commented on code in PR #3439: URL: https://github.com/apache/hugegraph/pull/3439#discussion_r4429087386
########## hugegraph-server/hugegraph-test/src/main/java/org/apache/hugegraph/unit/core/GraphSchemaCloneTest.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hugegraph.unit.core; + +import org.apache.hugegraph.HugeGraph; +import org.apache.hugegraph.core.GraphManager; +import org.apache.hugegraph.exception.HugeException; +import org.apache.hugegraph.schema.SchemaManager; +import org.apache.hugegraph.struct.schema.IndexLabel; +import org.apache.hugegraph.type.define.SchemaStatus; + +import com.google.common.collect.ImmutableList; +import org.junit.Assert; +import org.junit.Test; +import org.mockito.Mockito; + +public class GraphSchemaCloneTest { Review Comment: Important: the `unit-test` profile runs only `UnitTestSuite`, and `GraphSchemaCloneTest` is not listed there, so its partial-target and failed-index checks never run in CI. Add `GraphSchemaCloneTest.class` to `UnitTestSuite`. ########## hugegraph-server/hugegraph-test/src/main/java/org/apache/hugegraph/api/GraphsApiTest.java: ########## @@ -172,6 +172,72 @@ public void testCloneGraph() { } } + @Test + public void testCloneSchemaWithoutGraphData() { Review Comment: Important: `ApiTestSuite` does not list `GraphsApiTest`, so the three `schema-clone` endpoint tests never run in CI. Move them into `GraphsApiStandaloneTest`, which the suite runs, or register `GraphsApiTest` in `ApiTestSuite`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
