bitflicker64 commented on code in PR #886:
URL: 
https://github.com/apache/hugegraph-toolchain/pull/886#discussion_r4444259220


##########
hugegraph-hubble/hubble-be/src/main/java/org/apache/hugegraph/service/query/Text2GqlSettingsService.java:
##########
@@ -80,7 +80,7 @@ public Text2GqlRequest sharedRequest(Text2GqlRequest request) 
{
         }
         Text2GqlPrompts.validate(request.getPrompt());
         Snapshot current = this.current();
-        if (!current.configuration.isEnabled()) {
+        if (!configured(current.configuration)) {

Review Comment:
   Minor: with the `true` default and blank `base_url`/`model`, `settings()` 
reports `enabled: true`, so the settings page opens with the switch on and Test 
enabled, and Test then fails with `text2gql.shared.not-configured` ("has not 
been enabled by an administrator"), which contradicts the switch. Report 
`configured(configuration)` as `enabled` for deployment snapshots, or reword 
that message to say the base URL and model are missing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to