bitflicker64 commented on code in PR #889:
URL: 
https://github.com/apache/hugegraph-toolchain/pull/889#discussion_r4444260501


##########
hugegraph-hubble/hubble-fe/src/modules/asyncTasks/Home/index.js:
##########
@@ -39,7 +40,7 @@ const AsyncTaskHome = () => {
     const {graphSpace, graph} = useContext(GraphAnalysisContext);
     const [page, setPage] = useState(defaultPageParams.page);
     const [pageSize, setPageSize] = useState(defaultPageParams.pageSize);
-    const [searchCache, setSearchCache] = useState(taskId);
+    const [searchCache, setSearchCache] = useState(displayTaskId(taskId));

Review Comment:
   Important: for `taskId=-7` the box shows `7` while `search` stays `-7`, so 
`onSearch` on the untouched box sends `7`, which the backend matches against 
`Server #7`, `Vermeer #7` and names containing `7`, and drops the 
submitted-task view. Prefill `searchCache` with `displayTaskIdentity(taskId)` 
for negative IDs here and in the route effect, and add a test that pressing 
search on a Vermeer link keeps the same result.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to