bitflicker64 commented on code in PR #370:
URL: 
https://github.com/apache/hugegraph-computer/pull/370#discussion_r4452825003


##########
vermeer/apps/master/bl/worker_availability_test.go:
##########
@@ -45,6 +45,17 @@ type registrationWindowWorker struct {
        release chan struct{}
 }
 
+func TestRegistrationVersionMismatchReportsCorrectVersions(t *testing.T) {

Review Comment:
   Important: `vermeer-ci.yml` runs `./apps/master/bl` with `-run 
'Test(WorkerAvailability|HugegraphLoadAuthorization)'`, which does not match 
`TestRegistrationVersionMismatchReportsCorrectVersions`, so CI never runs this 
test. Add `RegistrationVersionMismatch` to that `-run` pattern.



##########
vermeer/apps/version/version.go:
##########
@@ -17,4 +17,4 @@ under the License.
 
 package version
 
-const Version = "1.7.0"
+const Version = "1.8.0"

Review Comment:
   Minor: `build.sh` and `build_docker.sh` read this with `grep 'Version'`, 
which also matches the license header's `Version 2.0` line, so `VERSION` 
becomes a newline followed by `1.8.0` and the tarball is named 
`vermeer-<newline>1.8.0-amd64.tar.gz`. Match `^const Version` there, as the new 
CI check does.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to