bosprimigenious opened a new pull request, #398: URL: https://github.com/apache/hugegraph-ai/pull/398
## Summary Closes #397. PropertyGraphExtract currently retains integer-zero vertices but silently discards their edges. A model-generated alias `0` also fails to resolve to a PRIMARY_KEY ID. ```diff - treat every falsy ID as missing + recognize integer 0 while keeping False/None/empty-string rejection ``` Use the same internal presence predicate for mapping vertices, resolving endpoints and filtering normalized edges. No public API, model, SDK, dependency or prompt change; this restores the existing single-operator ID contract rather than introducing a multi-file feature or cross-module design. The staged feature workflow is not claimed as approved. ## Evidence - **Before:** final 10 new regression cases against byte-identical original source: **4 fail, 6 pass**; the public `run` path drops an otherwise valid edge. - **After:** entire operator test file **46 pass**, one existing Pydantic class-config deprecation warning. Covers outgoing/incoming/self-loop integer zero, negative/ordinary/string controls, absent/False IDs, and a PRIMARY_KEY numeric alias. - Seven additional local operator boundary controls pass, including `False`/`0` dictionary-key collision controls, missing zero vertices and integer/string zero distinction. Socket guard observes **0 connections**. - Whole repository `ruff check .` and `ruff format --check .` pass (**581 files**); `ty check` on the changed source passes. Manifest ranges are unchanged, and this base has no tracked uv.lock. - Python **3.12.6**, uv-managed lightweight operator environment with exact resolved package inventory retained locally. Tests use the existing deterministic FakeLLM fixture, not a live provider. **Full acceptance NOT READY:** additional HTTP integration collection fails because this lightweight environment lacks `fastapi`. The full app dependency environment, CI coverage/platform matrix, HugeGraph Server and live model calls remain unverified. In particular, the separate existing numeric-ID write-through limitation in `CommitToHugeGraph` is not fixed here; this PR only restores local extraction and alias resolution. ## Merge Danger **Door:** two-way; no migration or stored-data changes. **Blast Radius:** extraction. Integer-zero references can now retain edges that were previously discarded; existing nonzero/string IDs and invalid/missing-ID controls remain covered. This is not general ID validation and does not newly accept float `0.0`. AI disclosure: patch, tests, analysis and this prose were prepared with OpenAI Codex. No human review is claimed. This independent bug is separate from the Ontogeny scope in #376/#380/#391, which already has public implementations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
