bitflicker64 commented on PR #393: URL: https://github.com/apache/hugegraph-ai/pull/393#issuecomment-6644063444
The earlier review comments below still apply at 5825b97; this head does not fix them. - Important: for release `hugegraph` the paired chart names the RAG Service `hugegraph-rag`, because `hugegraph.fullname` drops the chart suffix when the release name contains `hugegraph`, so this port-forward fails with `not found` and lines 181-182 send clients to a Service that does not exist. Use `hugegraph-rag` here and describe the new name as `<fullname>-rag` on lines 181-182. (https://github.com/apache/hugegraph-ai/pull/393#discussion_r4461349729) - Minor: this links fork PR `hugegraph/hugegraph-ai#96` as a prerequisite, and the mandatory merge order on line 9 omits its ASF counterpart `apache/hugegraph-ai#396`, so this retirement can merge before the configuration change it depends on. Link `apache/hugegraph-ai#396` here and on line 116, and add it to the merge order. (https://github.com/apache/hugegraph-ai/pull/393#discussion_r4465357482) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
