bitflicker64 commented on code in PR #3452:
URL: https://github.com/apache/hugegraph/pull/3452#discussion_r4491550163
##########
helm/rag_tests/validation.py:
##########
@@ -96,7 +96,7 @@ def test_invalid_contracts_fail_before_render(self):
({"env": [{"name": "BAD NAME", "value": "x"}]}, "Kubernetes 1.23"),
({"env": [{"name": "BAD\tNAME", "value": "x"}]}, "Kubernetes
1.23"),
({"env": [{"name": "GRAPH_URL", "value": "a"}, {"name":
"GRAPH_URL", "value": "b"}]}, "duplicate"),
- ({"persistance": {"enabled": False}}, "persistance"),
+ ({"persistence": {"enabled": False}}, "persistance"),
Review Comment:
Important: this case is in the `invalid` table on purpose: `{"persistance":
...}` exercises the `rag contains unsupported field %s` check in
`_rag_validate_fields.tpl`, while `{"persistence": {"enabled": False}}` is
valid and renders, so the subtest now fails with `AssertionError: 0 == 0`.
Revert this line to `({"persistance": {"enabled": False}}, "persistance")`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
