bitflicker64 commented on PR #896: URL: https://github.com/apache/hugegraph-toolchain/pull/896#issuecomment-6716739043
## Review summary (round 1) **Verdict:** Neither qualifying review found a defect introduced by this PR. Two of the four review lanes have reported so far, so the score below is provisional. **Reviewed:** FULL review of all 18 files (+160/−66). Base `0be65bf`, head `68a7273`. **Score:** 10.0 (mean of 2 of 4 reviewers) | Reviewer | Model | Raw score | Corrections | Adjusted score | |---|---|---|---|---| | Reviewer A | GPT-6 | 10.0 | none | 10.0 | | Reviewer B | Gemini 3.8 Flash | 10.0 | none | 10.0 | | Reviewer C | pending | N/A | N/A | N/A | | Reviewer D | pending | N/A | N/A | N/A | **Confirmed fixes:** - `asFileSource()` now keeps `time_zone` when it builds the source used to retry failed rows. - `GRAPH` input progress can now be read back. - The `RangesTimer` comparator no longer overflows. - `parseBoolean` puts the raw value and the key in the right order in its error message. The `instanceof` pattern-matching refactors keep the earlier behavior and match the module's Java 17 release level. `loadStructs` still rethrows the cause, or wraps it in a `RuntimeException`, and cleanup still runs in `finally`. This PR has no file overlap with #895. **Not part of this PR:** `asFileSource()` still does not copy `batchSize` or `splitCount`. That behavior predates this change and could be a follow-up. **Checks:** One reviewer ran the four new tests at both base and head. All four fail at base, and the loader unit suite passes at head (21/21). Integration tests were not run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
