bitflicker64 commented on PR #895: URL: https://github.com/apache/hugegraph-toolchain/pull/895#issuecomment-6716641620
## Review summary (round 1) **Verdict:** no blocking issues found. Ready from a code-review standpoint. **Reviewed:** `4ec460aa0c31140ba78fd78bed3d3a85f076e1bf` against `master` at `0be65bff`. Full review of all 18 files. **Score:** **10.0 / 10**, the mean of 2 of 4 independent reviews (provisional; later reports in this round will update this comment). | Reviewer | Model | Raw | Adjustments | Adjusted | |---|---|---|---|---| | Reviewer A | GPT-6 | 10.0 | none | 10.0 | | Reviewer B | Claude Opus 5.5 | 10.0 | none | 10.0 | | Reviewer C | pending | N/A | N/A | N/A | | Reviewer D | pending | N/A | N/A | N/A | **Confirmed issues:** none. **Non-blocking note:** `EdgeLabel.toString()` still throws an NPE when `links` is `null` (for example, JSON with `"links": null`). This is the same behavior as before this PR, so it was not counted. A `this.links != null` guard, matching `linkedVertexLabel()`, would complete the fix. **Checks:** the module targets Java 17 (root `pom.xml`), so `instanceof` pattern matching is valid. With the base `src/main` and the new tests, `UnitTestSuite` has 5 failures and 2 errors. At head it passes 160/160, and checkstyle is clean. There is no file overlap with the sibling PRs #896–#899. The API and functional suites were not run because they need a live server. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
