bitflicker64 commented on PR #3454: URL: https://github.com/apache/hugegraph/pull/3454#issuecomment-6716989505
## Review summary: round 1 (full review) **Verdict:** no confirmed defects; looks ready from the reviewers' side. Maintainer review still applies. **Reviewed:** the whole PR, all 8 files. Base `cd7f149`, head `2869208`. **Score:** 10.0/10, the mean of 2 of 4 planned independent reviews. Scores from the other two reviews will be added to this comment when they finish. | Reviewer | Model | Score | Adjusted | |---|---|---|---| | Reviewer A | not reported | 10 | 10 | | Reviewer B | Gemini 3.8 Flash | 10 | 10 | | Reviewer C | pending | N/A | N/A | | Reviewer D | pending | N/A | N/A | All four fixes match a reachable problem on the base branch: - **`AnalyzerFactory.register`:** custom analyzer names are now stored in lower case, so lookup can find them. - **`BinaryElementSerializer.edgeLabel`:** the label ids are now compared by value. A normal edge whose two equal-valued ids are separate objects is no longer marked `SUB`. - **`EdgeLabel`:** the target-side error messages now say "target". - **`DataType.valueToNumber`:** non-number types now return `null` for special float strings instead of failing. Conversions for number types are unchanged. The changes do not overlap the sibling PRs #3453 and #3455. **Checks and limits:** the related struct tests passed locally (14 tests). They ran on a JDK 21 toolchain targeting release 17 with the JDK version check skipped. Nobody confirmed that the new tests fail on the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
