bitflicker64 commented on PR #3453: URL: https://github.com/apache/hugegraph/pull/3453#issuecomment-6716883209
## Review summary: round 1 (full review) **Reviewed:** head `96ed9ba6fd5863a981f4fbc18a675f606af63f05` against base `cd7f1493b15858937d3684d72706d9681860bb9d`. The review covered the whole PR (3 files, +134/-3). **Verdict:** No defects were found. Both completed reviews confirmed the three fixes: - Only the `DIRECTION` key is decoded to `Directions`, so user-property values such as `"IN"`/`"OUT"` stay strings. - An empty `IN` list now serializes without the `values.get(0)` failure. - Removing or unsetting a condition on a query with no conditions is now a safe no-op instead of hitting the immutable `EMPTY_CONDITIONS`. **Score: 10.0 / 10 (2 of 4 reviews scored).** This is provisional. Two more reviews are still running, and this comment will be updated when they finish. | Reviewer | Model | Score (raw) | Adjusted | Findings | |---|---|---|---|---| | Reviewer A | not reported (Codex) | 10 | 10 | none | | Reviewer B | Gemini 3.8 Flash | 10 | 10 | none | | Reviewer C | — | pending | — | — | | Reviewer D | — | pending | — | — | **Checks:** Both reviewers ran the new `ConditionQueryCodecTest` against both commits. All 8 tests pass at the head, and at the base the test reproduces failures covering all three reported bugs. One reviewer also ran the full `hugegraph-struct` suite (144 tests), which passed. **Limits:** The tests were compiled with `--release 17` on a newer JDK, not run on a native Java 17 runtime. The distributed integration tests were not run. The PR does not touch the same files as #3454 or #3455. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
