imbajin commented on code in PR #3458:
URL: https://github.com/apache/hugegraph/pull/3458#discussion_r4505043590
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/backend/serializer/MergeIterator.java:
##########
@@ -57,10 +57,15 @@ public MergeIterator(Iterator<T> originIterator,
@Override
public void close() throws Exception {
- for (Iterator<R> iter : this.iterators) {
- if (iter instanceof AutoCloseable autoCloseable) {
- autoCloseable.close();
+ try {
+ for (Iterator<R> iter : this.iterators) {
Review Comment:
Fixed in e6bf435: close attempts every child and the origin, retaining the
first failure and suppressing later failures. Empty children are retained for
cleanup, and construction failures also close the supplied inputs. The new
regression cases failed before the fix; QueryResultsTest passed 26/26 afterward
on Java 21. Java 17 CI is pending.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
