imbajin commented on code in PR #3457:
URL: https://github.com/apache/hugegraph/pull/3457#discussion_r4505029888


##########
hugegraph-commons/hugegraph-common/src/main/java/org/apache/hugegraph/perf/PerfUtil.java:
##########
@@ -636,7 +636,14 @@ public V get(Object key) {
         }
 
         public V put(K key, V value) {
-            if (this.key1 == null) {
+            // Update the slot already holding this key before taking a free 
one

Review Comment:
   Fixed in d4b289a: equal but distinct keys now update and remove the cached 
mapping consistently, and null keys use the backing map. Regression cases 
failed before the fix; StopwatchTest passed 7/7 after the fix on Java 21. Java 
17 CI is pending.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to