imbajin commented on code in PR #3462:
URL: https://github.com/apache/hugegraph/pull/3462#discussion_r4505055677
##########
hugegraph-server/hugegraph-dist/src/main/java/org/apache/hugegraph/dist/HugeGremlinServer.java:
##########
@@ -87,7 +87,7 @@ public static GremlinServer startPrepared(GremlinServer
server)
LOG.error("Gremlin Server was unable to start and will " +
"shutdown now: {}", t.getMessage());
server.stop().join();
- throw new HugeException("Failed to start Gremlin Server");
+ throw new HugeException("Failed to start Gremlin Server", t);
Review Comment:
Fixed in 11ae7f2: the startup failure remains the primary cause when
stopping fails, and the stop failure is retained as suppressed. The synchronous
and asynchronous stop-failure regressions failed before the fix; all 3 targeted
tests passed afterward on Java 21. Java 17 CI is pending.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
