imbajin commented on PR #407:
URL: https://github.com/apache/hugegraph-ai/pull/407#issuecomment-6717791816

   ## Independent review
   
   Reviewed `d16a2f02288408e049590258bc4ddb10d28467ba`. Three independent lanes 
scored 10, 10 and 8: **9.3/10**. Two found no actionable issue; the adversarial 
lane identified a prompt-contract mismatch.
   
   **Finding:** the new validation and identity logic treat `DEFAULT` with 
primary keys as primary-key based, while the extraction, review and repair 
prompts still restrict those rules to `PRIMARY_KEY` or an undeclared strategy. 
A model following the prompts can omit a required key or choose an inconsistent 
ID and then fail local validation. The English and Chinese prompt paths should 
align with the conditional `DEFAULT` behavior, with a regression test through 
the actual prompt bundle.
   
   Reviewers inspected source and existing tests but did not independently run 
the extraction flow. A follow-up fix is in progress.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to