imbajin commented on code in PR #3456:
URL: https://github.com/apache/hugegraph/pull/3456#discussion_r4505027315
##########
hugegraph-commons/hugegraph-common/src/main/java/org/apache/hugegraph/iterator/BatchMapperIterator.java:
##########
@@ -43,6 +43,12 @@ public BatchMapperIterator(int batch, Iterator<T> origin,
this.batchIterator = null;
}
+ @Override
+ public void close() throws Exception {
+ this.resetBatchIterator();
Review Comment:
Fixed in 360d8c5: both iterators are closed even when the batch close fails,
and a second failure is retained as suppressed. Regression tests failed before
the fix and passed afterward (17/17 targeted tests on Java 21); Java 17 CI is
pending after the master update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
