bitflicker64 commented on PR #3450:
URL: https://github.com/apache/hugegraph/pull/3450#issuecomment-6644067677

   The earlier review comments below still apply at 0d458bc; this head does not 
fix them.
   
   - Important: the RAG Pod keeps Kubernetes service links, so a `qdrant` or 
`milvus` Service in the same namespace injects `QDRANT_PORT=tcp://<ip>:6333` or 
`MILVUS_PORT=tcp://<ip>:19530`, and `IndexConfig` raises `ValueError` at import 
on `int(os.environ.get("QDRANT_PORT", "6333"))`. Set `enableServiceLinks: 
false` in the RAG Pod spec. 
(https://github.com/apache/hugegraph/pull/3450#discussion_r4461350780)
   - Minor: with the documented release name `hugegraph`, `hugegraph.fullname` 
resolves to `hugegraph`, so the objects are `hugegraph-rag` and 
`hugegraph-rag-data`, and this command and those at lines 162, 269 and 291 
target `hugegraph-hugegraph-rag`, which does not exist. Use the real names, or 
select the Deployment by 
`app.kubernetes.io/instance=${RELEASE},app.kubernetes.io/component=rag`. 
(https://github.com/apache/hugegraph/pull/3450#discussion_r4461350786)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to