lplalbert commented on PR #416: URL: https://github.com/apache/hugegraph-ai/pull/416#issuecomment-6755335556
Agreed — pushed (17bd04c). Root cause: `is None` narrowing keeps `""` as an identity value, so distinct vertices with an empty primary key or empty declared id collide on the same `vid_mapping` key and merge their edges. Fix: `""` is treated as absent for identity values — single-pk vertices with `""` are skipped like missing ones, composite keys mark-empty (pre-#397 behavior), and an empty declared id falls back to the composite mapping so edges resolve. `0` and `False` stay values, and the `CUSTOMIZE_STRING` guard behavior is unchanged. This matches the extraction layer, which already treats empty ids/endpoints as absent (`if original_id:`, `if endpoint and label:`). Tests: three regressions in `test_commit_to_hugegraph_load_into_graph.py` (empty single pk dropped, empty composite part marked empty, empty declared id resolves via composite keys), red-green verified (3 failed without the fix). 55 passed in hugegraph_op; ruff clean; ty baseline 271 held. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
