mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r247745842
########## File path: core/src/main/java/com/netflix/iceberg/BaseMetastoreTableOperations.java ########## @@ -52,8 +47,8 @@ private static final String HIVE_LOCATION_FOLDER_NAME = "empty"; private final Configuration conf; - private final FileIO fileIo; + private HadoopFileIO fileIo; Review comment: Now it does because we specifically refresh the metadata on it (this really should be `defaultFileIo` though). However, perhaps part of the question is if `updateMetadata` should be part of the `FileIO` API contract too. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
