rdblue commented on a change in pull request #73: Allow data output streams to
be generated via custom mechanisms when given partitioning and file name
URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248507495
##########
File path: spark/src/main/java/com/netflix/iceberg/spark/source/Writer.java
##########
@@ -327,11 +261,11 @@ public WriterCommitMessage commit() throws IOException {
close();
if (metrics.recordCount() == 0L) {
- fileIo.deleteFile(file);
+ fileIo.deleteFile(file.location());
return new TaskCommit();
}
- InputFile inFile = fileIo.newInputFile(file);
+ InputFile inFile = fileIo.newInputFile(file.location());
Review comment:
What about `file.toInputFile()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
