mccheah commented on a change in pull request #85: Encryption APIs for Iceberg.
URL: https://github.com/apache/incubator-iceberg/pull/85#discussion_r253167418
##########
File path: api/src/main/java/com/netflix/iceberg/Table.java
##########
@@ -185,4 +186,13 @@ default AppendFiles newFastAppend() {
*/
FileIO io();
+ /**
+ * @return an {@link com.netflix.iceberg.encryption.EncryptionManager} to
encrypt and decrypt
+ * data files.
+ */
+ default EncryptionManager encryption() {
Review comment:
On the write side, there's a question of if enabling encryption should be
done on the per-job (e.g. Spark datasource option), per-table (Table property),
or globally (encryption manager is always used).
If we want to say that enabling encryption is done on the table property or
as an option for the job, then we always want to return some encryption manager
that does some best effort encryption and key storage, as we do in
https://github.com/mccheah/incubator-iceberg/pull/2.
Also what would a plaintext encryption manager return as the key metadata?
Likely would just be a null byte buffer in that case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
