rdblue commented on a change in pull request #87: Add LocationProvider to
determine data file locations.
URL: https://github.com/apache/incubator-iceberg/pull/87#discussion_r253234795
##########
File path: spark/src/main/java/com/netflix/iceberg/spark/source/Writer.java
##########
@@ -96,7 +87,8 @@
@Override
public DataWriterFactory<InternalRow> createWriterFactory() {
- return new WriterFactory(table.spec(), format, dataLocation(),
table.properties(), fileIo);
+ return new WriterFactory(
+ table.spec(), format, table.locationProvider(), table.properties(),
fileIo);
Review comment:
Yeah, Serialization. WriterFactory has to be Serializable and Table isn't
Serializable. We could pass Table to its constructor, assuming that the
implementation knows not to keep a reference to it, but I think it is cleaner
and more maintainable to not pass non-serializable objects in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
