rdblue commented on issue #90: Add finalizer for Hadoop streams to catch paths that don't call close. URL: https://github.com/apache/incubator-iceberg/pull/90#issuecomment-460717789 @fbocse, this is not the intended way to clean up resources. This is a way to handle leaks so that you get nice warning messages instead of failing applications when a resource pool runs out. Iceberg already uses try-with-resources and is careful about cleaning up open files internally, but it also returns open streams to callers as `CloseableIterable` instances. If callers leave those open, a finalizer is better than doing nothing.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
