aokolnychyi commented on issue #90: Add finalizer for Hadoop streams to catch paths that don't call close. URL: https://github.com/apache/incubator-iceberg/pull/90#issuecomment-464754309 Has anybody experienced the exception below? One way to reproduce this is to run `TestParquetWrite`. ``` [Finalizer] WARN com.netflix.iceberg.hadoop.HadoopStreams - Unclosed input stream created by: com.netflix.iceberg.hadoop.HadoopStreams$HadoopSeekableInputStream.<init>(HadoopStreams.java:78) com.netflix.iceberg.hadoop.HadoopStreams.wrap(HadoopStreams.java:53) com.netflix.iceberg.hadoop.HadoopInputFile.newStream(HadoopInputFile.java:125) com.netflix.iceberg.avro.AvroIterable.newFileReader(AvroIterable.java:95) com.netflix.iceberg.avro.AvroIterable.iterator(AvroIterable.java:77) com.google.common.collect.Iterables$6.iterator(Iterables.java:585) com.google.common.collect.Iterables$8.iterator(Iterables.java:709) com.netflix.iceberg.ManifestReader.iterator(ManifestReader.java:225) com.netflix.iceberg.FilteredManifest.iterator(FilteredManifest.java:124) com.google.common.collect.Iterables$8.iterator(Iterables.java:709) com.google.common.collect.Iterables$3.transform(Iterables.java:508) com.google.common.collect.Iterables$3.transform(Iterables.java:505) com.google.common.collect.TransformedIterator.next(TransformedIterator.java:48) com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) com.netflix.iceberg.util.BinPacking$PackingIterator.hasNext(BinPacking.java:91) com.netflix.iceberg.io.CloseableIterable$4$1.hasNext(CloseableIterable.java:92) com.google.common.collect.Iterators.addAll(Iterators.java:356) com.google.common.collect.Lists.newArrayList(Lists.java:147) com.google.common.collect.Lists.newArrayList(Lists.java:129) com.netflix.iceberg.spark.source.Reader.tasks(Reader.java:209) com.netflix.iceberg.spark.source.Reader.planInputPartitions(Reader.java:135) org.apache.spark.sql.execution.datasources.v2.DataSourceV2ScanExec.partitions$lzycompute(DataSourceV2ScanExec.scala:76) ... ``` It seems `ManifestReader` is not closed properly in some cases. `ManifestReader` is `CloseableGroup` and we add `AvroIterable` to the list of closeables. However, `ManifestReader$close` is not called.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
