rdblue commented on a change in pull request #106: Deep copy maps and lists in
GenericDataFile.
URL: https://github.com/apache/incubator-iceberg/pull/106#discussion_r258690224
##########
File path: core/src/main/java/com/netflix/iceberg/GenericDataFile.java
##########
@@ -405,4 +406,17 @@ public String toString() {
.toString();
}
+ private static <K, V> Map<K, V> copy(Map<K, V> map) {
+ if (map != null) {
+ return ImmutableMap.copyOf(map);
Review comment:
There should be no null keys in these maps because they are built
internally. If these were passed from user code, I would agree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
