prodeezy commented on a change in pull request #110: Fix Iceberg Parquet Reader
scanning when filtering on nested types
URL: https://github.com/apache/incubator-iceberg/pull/110#discussion_r259583268
##########
File path:
parquet/src/main/java/com/netflix/iceberg/parquet/ParquetMetricsRowGroupFilter.java
##########
@@ -156,6 +157,13 @@ public Boolean or(Boolean leftResult, Boolean
rightResult) {
Preconditions.checkNotNull(struct.field(id),
"Cannot filter by nested column: %s", schema.findField(id));
+ // When filtering nested types notNull() is implicit filter passed even
Review comment:
Re: Spark passing down notNull(a) , yes, It's an implicit filter passed
down when one uses nested types in filters.
Re: other such cases.
Equals case might be affected, will add the fix to that case as well. The
isNull(col) doesn't need fixing as it returns ROWS_MIGHT_MATCH when valueCounts
is checked. The notEqual case returns ROWS_MIGHT_MATCH by default so this might
not apply there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
