aokolnychyi commented on issue #78: Collect min/max value statistics for nested 
structs in ParquetMetrics
URL: 
https://github.com/apache/incubator-iceberg/issues/78#issuecomment-467450491
 
 
   @rdblue I see a comment in `ParquetMetrics$fromMetadata`, which says `TODO: 
allow struct nesting, but not maps or arrays`.
   
   Could you describe why we need to exclude maps and arrays? We have proper 
statistics for keys/values in maps as well as for elements in lists, don't we? 
For example, we might support predicates on elements of lists at some point.
   
   I am asking because the simplest option to enable statistics for nested 
structs is by replacing `fileSchema.asStruct().field(fieldId)` with 
`fileSchema.findField(fieldId)` in `ParquetMetrics$fromMetadata`. If we want to 
collect statistics only for nested structs, the logic will be more complicated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to