rdblue commented on a change in pull request #111: Split files when planning
scan tasks
URL: https://github.com/apache/incubator-iceberg/pull/111#discussion_r260397600
##########
File path: core/src/main/java/com/netflix/iceberg/BaseTableScan.java
##########
@@ -208,8 +211,8 @@ public InclusiveManifestEvaluator load(Integer specId) {
TableProperties.SPLIT_LOOKBACK,
TableProperties.SPLIT_LOOKBACK_DEFAULT);
return CloseableIterable.transform(
- CloseableIterable.wrap(planFiles(), files ->
- new BinPacking.PackingIterable<>(files, splitSize, lookback,
FileScanTask::length)),
+ CloseableIterable.wrap(planSplits(splitSize), splits ->
+ new BinPacking.PackingIterable<>(splits, splitSize, lookback,
FileScanTask::length)),
Review comment:
The approach here looks good: take the output of `planFiles`, split files to
produce a new iterable, and then pack those splits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
