fbocse commented on a change in pull request #108: Use the current schema in
all partition specs in scan planning.
URL: https://github.com/apache/incubator-iceberg/pull/108#discussion_r259523682
##########
File path: core/src/main/java/com/netflix/iceberg/BaseTableScan.java
##########
@@ -154,6 +155,16 @@ public InclusiveManifestEvaluator load(Integer specId) {
}
});
+ private final LoadingCache<Integer, Expression> PARTITION_EXPR_CACHE =
CacheBuilder
+ .newBuilder()
Review comment:
Nit: what's the eviction policy, LRU? Is there a default max size or does it
stretch over all available memory?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
