rdblue commented on a change in pull request #107: Integrate encryption into
datasource
URL: https://github.com/apache/incubator-iceberg/pull/107#discussion_r261717377
##########
File path: core/src/main/java/com/netflix/iceberg/TableOperations.java
##########
@@ -66,10 +66,7 @@
* @return a {@link com.netflix.iceberg.encryption.EncryptionManager} to
encrypt and decrypt
* data files.
*/
- default EncryptionManager encryption() {
- // TODO coming soon
- throw new UnsupportedOperationException("Encryption is a work in
progress.");
- }
+ EncryptionManager encryption();
Review comment:
Because this is part of the service-provider interface and not the public
API, I think we should consider keeping the default implementation and update
it to return the `PlaintextEncryptionManager`. That would cut down on the files
that this touches a bit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
