rdblue commented on a change in pull request #109: Remove unused in-memory
ManifestReader code.
URL: https://github.com/apache/incubator-iceberg/pull/109#discussion_r262637609
##########
File path: core/src/main/java/com/netflix/iceberg/ManifestReader.java
##########
@@ -187,11 +165,6 @@ private void cacheChanges() {
}
CloseableIterable<ManifestEntry> entries(Collection<String> columns) {
- if (entries != null) {
- // if this reader is an in-memory list or if the entries have been
cached, return the list.
- return CloseableIterable.withNoopClose(entries);
Review comment:
We may still find a use for it, so I think we should leave it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
