rdblue commented on a change in pull request #119: Split files when planning
scan tasks
URL: https://github.com/apache/incubator-iceberg/pull/119#discussion_r263588578
##########
File path: core/src/main/java/com/netflix/iceberg/BaseFileScanTask.java
##########
@@ -74,4 +87,74 @@ public String toString() {
.add("residual", residual())
.toString();
}
+
+ private static final class SplitScanTaskIterator implements
Iterator<FileScanTask> {
Review comment:
I'd like to see a unit test for this class that has a few example split
cases, like file length = 100 and split size = 15 produces [0, 15), [15, 30),
[30, 45), etc. That ensures there are no gaps between splits. Just reading data
files doesn't make that guarantee.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
