prodeezy commented on a change in pull request #123: Add support for struct
field based filtering
URL: https://github.com/apache/incubator-iceberg/pull/123#discussion_r265467750
##########
File path:
api/src/main/java/com/netflix/iceberg/expressions/BoundReference.java
##########
@@ -32,19 +32,41 @@
BoundReference(Types.StructType struct, int fieldId) {
this.fieldId = fieldId;
- this.pos = find(fieldId, struct);
- this.type = struct.fields().get(pos).type();
+ this.pos = findTopFieldPos(fieldId, struct);
Review comment:
Yeah, good point. going to write some unit tests to evaluate impact. will
handle accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
