aokolnychyi commented on a change in pull request #131: Fix collection of
bounds for small decimals in ParquetMetrics
URL: https://github.com/apache/incubator-iceberg/pull/131#discussion_r266093218
##########
File path:
parquet/src/main/java/com/netflix/iceberg/parquet/ParquetMetrics.java
##########
@@ -86,9 +86,9 @@ public static Metrics fromMetadata(ParquetMetadata metadata)
{
Types.NestedField field = fileSchema.asStruct().field(fieldId);
if (field != null && stats.hasNonNullValue()) {
updateMin(lowerBounds, fieldId,
- fromParquetPrimitive(field.type(), stats.genericGetMin()));
+ fromParquetPrimitive(field.type(), column.getPrimitiveType(),
stats.genericGetMin()));
Review comment:
Would no longer fit into 100 characters per line. Do we have such a
requirement? I've seen a couple of places where this is not respected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
