rominparekh commented on a change in pull request #117: Sorts bin packing by
weights in descending order
URL: https://github.com/apache/incubator-iceberg/pull/117#discussion_r266715706
##########
File path: core/src/main/java/com/netflix/iceberg/util/BinPacking.java
##########
@@ -33,20 +34,22 @@
public static class ListPacker<T> {
private final long targetWeight;
private final int lookback;
+ private final boolean expensiveTaskFirst;
- public ListPacker(long targetWeight, int lookback) {
+ public ListPacker(long targetWeight, int lookback, boolean
expensiveTaskFirst) {
Review comment:
@rdblue Arguably no. But since it does support an API to instantiate a
`PackingIterable`, I thought to keep the semantics same and allow argument to
be passed via `ListPacker`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
