rominparekh commented on a change in pull request #134: Adding Drop and Rename
APIs to Tables interface.
URL: https://github.com/apache/incubator-iceberg/pull/134#discussion_r267046527
##########
File path: api/src/main/java/com/netflix/iceberg/Tables.java
##########
@@ -43,4 +43,13 @@ Table create(Schema schema,
String tableIdentifier);
Table load(String tableIdentifier);
+
+ /**
+ * Drop a table from iceberg catalog, the underlying implementation
+ * may or may not drop the corresponding metadata and data.
+ * @param tableIdentifier
+ */
+ void drop(String tableIdentifier);
+
+ void rename(String oldTableIdentifier, String newTableIdentifier);
Review comment:
How about we provide a flag to create parent directories if necessary? A
properties map will be a cleaner future proof contract.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
