prodeezy commented on a change in pull request #136: Collect lower/upper bounds
for nested struct fields in ParquetMetrics
URL: https://github.com/apache/incubator-iceberg/pull/136#discussion_r267181266
##########
File path:
parquet/src/main/java/com/netflix/iceberg/parquet/ParquetMetrics.java
##########
@@ -105,6 +107,22 @@ public static Metrics fromMetadata(ParquetMetadata
metadata) {
toBufferMap(fileSchema, lowerBounds), toBufferMap(fileSchema,
upperBounds));
}
+ // we allow struct nesting, but not maps or arrays
Review comment:
The comment can be a bit more descriptive of the fact that this check also
precludes structs containing maps or array and vice versa.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
