xabriel commented on a change in pull request #141: Add case insensitive
support to Parquet.
URL: https://github.com/apache/incubator-iceberg/pull/141#discussion_r267839947
##########
File path:
spark/src/test/java/com/netflix/iceberg/spark/data/TestParquetAvroReader.java
##########
@@ -101,10 +99,11 @@ public void testStructSchema() throws IOException {
// clean up as much memory as possible to avoid a large GC during the
timed run
System.gc();
- try (ParquetReader<Record> reader = new ParquetReader<>(
- Files.localInput(testFile), structSchema,
ParquetReadOptions.builder().build(),
- fileSchema -> ParquetAvroValueReaders.buildReader(structSchema,
readSchema),
- Expressions.alwaysTrue(), true)) {
+ try (CloseableIterable<Record> reader =
Parquet.read(Files.localInput(testFile))
+ .project(structSchema)
+ .createReaderFunc(
+ fileSchema -> ParquetAvroValueReaders.buildReader(structSchema,
readSchema))
+ .build()) {
Review comment:
These changes to `TestParquetAvroReader.java` seem unrelated to PR
intention. Can you explain?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
