rdblue commented on a change in pull request #141: Add case insensitive support
to Parquet.
URL: https://github.com/apache/incubator-iceberg/pull/141#discussion_r268006411
##########
File path:
parquet/src/main/java/com/netflix/iceberg/parquet/ParquetMetricsRowGroupFilter.java
##########
@@ -56,9 +56,13 @@ private MetricsEvalVisitor visitor() {
}
public ParquetMetricsRowGroupFilter(Schema schema, Expression unbound) {
+ this(schema, unbound, true);
+ }
+
+ public ParquetMetricsRowGroupFilter(Schema schema, Expression unbound,
boolean caseSensitive) {
this.schema = schema;
this.struct = schema.asStruct();
- this.expr = Binder.bind(struct, rewriteNot(unbound), true);
+ this.expr = Binder.bind(struct, rewriteNot(unbound), false);
Review comment:
Yep. Good catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
